forked from 1b-agent/opencadstudio-upstream
perf: instrument the file-open load path behind PERF
The 52 s silent stretch in a large-DWG open could not be attributed:
OpenTimings covered parse / purge / xref / caches, but the FINALIZING
phase -- prepare_open_geometry, which does the first full Model
tessellation and builds the interaction index -- was unmeasured and
reports only two progress ticks, so it was indistinguishable from parse
time.
Add finalize_ms to OpenTimings and a per-stage PERF breakdown:
open-phases parse / purge / xref / caches / finalize
open-finalize tessellation vs interaction index
open-index index build vs prepare_screen
wires-build sort cache, visible filter, block cache, classify,
memo hits, parallel tessellate, materialize, sort
resident-post scene markers, refedit fade, resident layout
wire-upload build_wire_buffers, which runs on the render thread
The wires-build line separates the parallel tessellate from the serial
materialize loop that deep-clones every WireModel while the memo retains
a second copy -- the leading hypothesis for both the stall and the
6.45 GB RSS.
No behaviour change. Every timer is gated on crate::perf::enabled(), so
nothing runs without PERF=1 or the in-app PERF panel. The localized
open-summary format string is left alone; changing it would rekey the
string across every locale, so the full breakdown goes to PERF instead.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
886d5777d8
commit
2787dcc1a3
4 files changed
+137
-2
No files matched your search
@@ -373,6 +373,7 @@ impl RecoveryReport {
|
||||
lines.push(format!("Validation: {} ms", self.timings.purge_ms));
|
||||
lines.push(format!("References: {} ms", self.timings.xref_ms));
|
||||
lines.push(format!("Scene caches: {} ms", self.timings.caches_ms));
|
||||
lines.push(format!("Geometry prep: {} ms", self.timings.finalize_ms));
|
||||
lines.push(format!("Total: {} ms", self.total_ms));
|
||||
if !self.diagnostics.is_empty() {
|
||||
lines.push(String::new());
|
||||
|
||||
Reference in new issue
Block a user