1b-agent/OneCAD-Draft
1
0 Fork 0
forked from 1b-agent/opencadstudio-upstream
Code Pull Requests Activity

feat(dgn-ls): dash walls from start + fix wall connector and cap identity

Browse Source 
DET pipe walls now carry the stroke pattern (dash_from_start), which
tiles from each wall's own start vertex and skips the A-type end
alignment that was force-lighting a solid dash under the end symbol.

Two rendering fixes on top:
- Dedup the host polyline's vertices before offsetting the walls. Some
  DGN pipe polylines carry trailing duplicate end vertices; a zero-length
  segment gave offset_xy a degenerate normal, leaving that vertex
  un-offset and folding the wall down to the centre line. The two walls'
  fold segments met at the centre and drew a spurious line linking them.
- Re-key the symbol (end circle / half-ellipse) wires to the host handle
  so the whole pipe picks and selects as one entity instead of the
  symbols acting as separate phantom entities.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Hakan SevenandClaude Opus 4.8 committed 2026-07-17 01:49:18 +03:00
1 parent 765e6606e2
commit 48e6d0d553
42 files changed
+124 -8
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/scene/convert/tessellate.rs
+17
View File
@@ -313,6 +313,7 @@ pub fn tessellate(
)
};
elem_wires.push(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: name.clone(),
points: pts,
@@ -587,6 +588,7 @@ pub fn tessellate(
ftl.push(lo);
}
wires.push(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: name.clone(),
points: vec![],
@@ -620,6 +622,7 @@ pub fn tessellate(
fpl.push(lo);
}
wires.push(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: name.clone(),
points: fp,
@@ -660,6 +663,7 @@ pub fn tessellate(
low.push(ll);
}
wires.push(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: name.clone(),
points: pts,
@@ -681,6 +685,7 @@ pub fn tessellate(
});
}
wires.push(WireModel {
dash_from_start: false,
text_verts: sdf_verts,
name,
points: Vec::new(),
@@ -732,6 +737,7 @@ pub fn tessellate(
(Vec::new(), Vec::new(), Vec::new())
};
out.push(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: name.clone(),
points: bin.pts,
@@ -765,6 +771,7 @@ pub fn tessellate(
(Vec::new(), Vec::new(), Vec::new())
};
out.push(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: name.clone(),
points: Vec::new(),
@@ -795,6 +802,7 @@ pub fn tessellate(
// are empty → the early-return path above).
if !sdf_verts.is_empty() {
out.push(WireModel {
dash_from_start: false,
text_verts: sdf_verts,
name: name.clone(),
points: Vec::new(),
@@ -818,6 +826,7 @@ pub fn tessellate(
if out.is_empty() {
out.push(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name,
points: Vec::new(),
@@ -863,6 +872,7 @@ pub fn tessellate(
.map(|[kx, ky, kz]| [kx, ky, kz])
.collect();
return vec![WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name,
points: vec![
@@ -907,6 +917,7 @@ pub fn tessellate(
.map(|[x, y, z]| [x, y, z])
.collect();
return vec![WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name,
points,
@@ -940,6 +951,7 @@ pub fn tessellate(
.map(|[x, y, z]| [x, y, z])
.collect();
return vec![WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name,
points,
@@ -992,6 +1004,7 @@ pub fn tessellate(
(Vec::new(), Vec::new(), Vec::new())
};
out.push(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: name.clone(),
points: local_pts,
@@ -1024,6 +1037,7 @@ pub fn tessellate(
(Vec::new(), Vec::new(), Vec::new())
};
out.push(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name: name.clone(),
points: Vec::new(),
@@ -1047,6 +1061,7 @@ pub fn tessellate(
if out.is_empty() {
out.push(WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name,
points: Vec::new(),
@@ -1080,6 +1095,7 @@ pub fn tessellate(
.map(|[x, y, z]| [x, y, z])
.collect();
return vec![WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name,
points: local_pts,
@@ -1144,6 +1160,7 @@ pub fn tessellate(
let snap_pts: Vec<(glam::DVec3, SnapHint)> =
snap_pts.into_iter().map(|(p, h)| (p.as_dvec3(), h)).collect();
vec![WireModel {
dash_from_start: false,
text_verts: Vec::new(),
name,
points,