fix: one VRAM-aware buffer budget for every GPU upload path

max_buffer_size is an API validation limit, not physical VRAM. NVIDIA
reports several GB of it on a 2 GB card, so sizing a chunk from it
produces buffers larger than the whole device. That is the same bug as
#203 (mesh_gpu), #358 (face3d_gpu) and the block-wire vertex buffer:
rediscovered three times because each upload path spelled the budget out
for itself.

mesh_gpu.rs was the only site that clamped the result. Move that clamp
into src/scene/pipeline/gpu_budget.rs and route every allocating path
through it, so a new upload path cannot reintroduce the mistake by
copying one of the unclamped expressions.

Five sites had no clamp at all: text_gpu (block-text instances),
wire_gpu (block-wire instances), and face3d_gpu (vertices, instances,
and upload_chunks).

Three behaviour changes worth noting:

  * Silhouette chunks were capped at a private 64 MiB constant and now
    use the shared 32 MiB budget.
  * The storage-hatch chunk limit was the minimum of two device limits,
    both of them validation figures; it is now also capped by the
    budget. The `*_fits` predicates next to it are genuine "would wgpu
    reject this" checks and are left alone.
  * mesh_gpu's instanced path used the unclamped ceiling to decide
    whether a mesh fits in a single buffer, which would still admit a
    multi-GB allocation. It now uses the clamped budget, so a few more
    meshes take the chunked path.

OCS_GPU_CHUNK_MIB overrides the cap. Raising it above the real VRAM is
the cheapest way to force an allocation failure and check that the
renderer degrades instead of aborting.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
PanosandClaude Opus 5 committed 2026-09-04 16:20:38 +03:00
1 parent 8552450aa8
commit 771a5b2c5c
7 files changed
+84 -35

No files matched your search

+5 -1
View File
@@ -196,9 +196,13 @@ impl StorageHatchBatch {
}
let limits = device.limits();
// Both device figures are API validation limits, not physical VRAM, so
// the shared budget caps them (`storage.rs` chunks are allocations, not
// just size checks — the `*_fits` predicates below are the checks).
let chunk_limit = limits
.max_buffer_size
.min(limits.max_storage_buffer_binding_size as u64);
.min(limits.max_storage_buffer_binding_size as u64)
.min(crate::scene::pipeline::gpu_budget::buffer_budget(device) as u64);
let mut ranges = Vec::new();
let mut start = 0;
let mut used = [0u64; 7];