Map Viewport in the Python host model

Curated view fields are writable; the owner must be a paper-space block and
frozen layers must exist. staged_python_viewport_lifecycle_over_real_ipc
passes every gate except a paper-space canvas oracle, so the kind is
recorded as integration-tested.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Felix RiestraandClaude Sonnet 5 committed 2026-09-20 15:09:23 +02:00
1 parent 2e4d77dc09
commit 9075e53511
10 files changed
+219 -14

No files matched your search

+54 -3
View File
@@ -3195,6 +3195,11 @@ mod tests {
let tmp = std::env::temp_dir().to_string_lossy().into_owned();
let mut create_script = case.create.replace("TMPDIR", &tmp);
let paper = host.document().block_records.iter().find(|r| r.is_paper_space()).map(|r| r.handle.value());
let layer0 = host.document().layers.iter().find(|l| l.name == "0").map(|l| l.handle.value());
create_script = create_script
.replace("PAPERSPACE", &paper.unwrap_or_default().to_string())
.replace("LAYER0", &layer0.unwrap_or_default().to_string());
if create_script.contains("DEFHANDLE") {
// Scripts reference an underlay definition that the drawing owns.
let handle = host.document_mut().allocate_handle();
@@ -3209,14 +3214,21 @@ mod tests {
.unwrap_or_else(|| panic!("Python did not create the mesh: {}", last_output(&host)));
let created = host.document().get_entity(handle).unwrap().clone();
assert_eq!((case.digest)(&created), case.expect_created);
assert!(!host.app.tabs[0].scene.wire_models_for(&[handle]).is_empty(), "no canvas geometry");
// Viewports draw only on their paper-space layout tab, which this
// driver does not activate, so they have no model-tab wire oracle.
let has_wires = !matches!(created, EntityType::Viewport(_));
if has_wires {
assert!(!host.app.tabs[0].scene.wire_models_for(&[handle]).is_empty(), "no canvas geometry");
}
run_script(&mut host, "edit", &case.edit.replace("HANDLE", &handle.value().to_string()).replace("TMPDIR", &tmp));
run_script(&mut host, "edit", &case.edit.replace("HANDLE", &handle.value().to_string()).replace("TMPDIR", &tmp).replace("LAYER0", &layer0.unwrap_or_default().to_string()));
let expected = host.document().get_entity(handle).unwrap().clone();
assert_eq!((case.digest)(&expected), case.expect_edited, "edit failed: {}", last_output(&host));
assert_eq!(expected.common(), created.common());
assert_eq!(host.selection(), vec![handle]);
assert!(!host.app.tabs[0].scene.wire_models_for(&[handle]).is_empty());
if has_wires {
assert!(!host.app.tabs[0].scene.wire_models_for(&[handle]).is_empty());
}
for (patch, message) in case.rejects {
dispatch(&mut host, &format!(
@@ -3586,6 +3598,45 @@ mod tests {
});
}
#[test]
fn staged_python_viewport_lifecycle_over_real_ipc() {
run_mesh_lifecycle(&MeshCase {
create: concat!(
"doc.create_entity('Viewport', owner_handle=PAPERSPACE, center=P(100.0, 100.0, 0.0),\n",
" width=80.0, height=60.0, view_center=P(0.0, 0.0, 0.0), view_height=50.0)\n"),
edit: concat!(
"vp = doc.entities[HANDLE]\n",
"with doc.transaction('Edit viewport'):\n",
" vp.center = (120.0, 110.0, 0.0)\n",
" vp.width = 90.0\n",
" vp.view_height = 75.0\n",
" vp.twist_angle = 0.25\n",
" vp.frozen_layers = [LAYER0]\n",
"doc.selection = [vp]\n"),
rejects: &[
("'width':0.0", "greater than zero"),
("'view_height':float('nan')", "greater than zero"),
("'view_direction':{'x':0.0,'y':0.0,'z':0.0}", "nonzero"),
("'frozen_layers':[999999]", "does not exist"),
("'circle_sides':2", "at least 3"),
("'id':7", "read-only"),
("'clip_boundary_handle':5", "read-only"),
],
is_kind: |entity| matches!(entity, EntityType::Viewport(_)),
digest: |entity| match entity {
EntityType::Viewport(v) => format!("at{:.1},{:.1} {:.1}x{:.1} vh{:.1} tw{:.2} frozen{}", v.center.x, v.center.y,
v.width, v.height, v.view_height, v.twist_angle, v.frozen_layers.len()),
_ => "wrong kind".into(),
},
reedit: |entity| if let EntityType::Viewport(v) = entity { v.width = 95.0; },
expect_created: "at100.0,100.0 80.0x60.0 vh50.0 tw0.00 frozen0",
expect_edited: "at120.0,110.0 90.0x60.0 vh75.0 tw0.25 frozen1",
expect_reedited: "at120.0,110.0 95.0x60.0 vh75.0 tw0.25 frozen1",
expect_edited_dxf: "",
expect_reedited_dxf: "",
});
}
#[test]
fn staged_python_point_pick_and_cancel_over_real_ipc() {
let Some(plugin_path) = std::env::var_os("OCS_TEST_PYTHON_PLUGIN") else {