From c7c698eaaded7da2bdb1f67b239c5b99ee228b84 Mon Sep 17 00:00:00 2001 From: Felix Riestra Date: Mon, 21 Sep 2026 22:27:43 +0200 Subject: [PATCH] docs: refresh the review guide and plan after merging upstream main Co-Authored-By: Claude Sonnet 5 --- docs/plugin-host-model-completion-plan.md | 11 +++++++++-- docs/plugin-host-review-guide.md | 17 ++++++++++------- 2 files changed, 19 insertions(+), 9 deletions(-) diff --git a/docs/plugin-host-model-completion-plan.md b/docs/plugin-host-model-completion-plan.md index 87a6377b2..bc534b0a1 100644 --- a/docs/plugin-host-model-completion-plan.md +++ b/docs/plugin-host-model-completion-plan.md @@ -348,6 +348,13 @@ files, settings and the lockfile), on a `pr-check-*` tag and by hand, on `ubuntu (`--features host`), staging the bundled plugin and building the runner, the plugin crate tests, the Python model unit tests, and the host's real-IPC tests. It fails outright if the staged plugin or the runner is missing, because those tests otherwise skip and report success. First run (`pr-check-1`, commit `1f8cbb81`, all green on both platforms): 115 plugin API tests, 20 plugin crate tests, 16 Python model tests and 60 real-IPC -host tests on each. Debug build, so a cold run is about 30 minutes and a cached one much less. The whole lib suite is deliberately not run there: -two unrelated tests fail on upstream `main` in the environments checked (see the earlier notes). +host tests on each. Debug build, so a cold run is about 30 minutes and a cached one much less. The whole lib suite is deliberately not run by that workflow, because `main`'s own `Tests` workflow (`cargo test --workspace --locked`, added upstream on 21 September) runs it on every pull request. Against the merged tree that command gives 1,805 passed and 1 failed locally on macOS, `fonts_parse_and_resolve`, which also fails on pristine `main` there. + +### 2026-09-21: merged upstream `main` (25 commits) + +Merged `origin/main` at its head (no conflicts). Upstream added `.github/workflows/ci.yml` (`cargo test --workspace --locked` on Linux for every +pull request, `LC_ALL=C`), removed the Nix files, and added parametric-constraint and viewport-plot changes. Re-verified on the merged tree: the +plugin gate (60 real-IPC host tests, 115 plugin API, 20 plugin crate, 16 Python model), the wasm check, and the upstream workspace command with +`--no-fail-fast` (1,805 passed, 1 failed: `fonts_parse_and_resolve`, which fails on pristine `main` on this Mac too; `arc_grips_drive_center_start_and_end_but_not_midpoint` +now passes, fixed upstream). The change is 75 files, +30,833 / -178 against current `main`. diff --git a/docs/plugin-host-review-guide.md b/docs/plugin-host-review-guide.md index 0837accaa..ad62bd4e4 100644 --- a/docs/plugin-host-review-guide.md +++ b/docs/plugin-host-review-guide.md @@ -21,10 +21,10 @@ refuses without changing anything when it cannot honour a request. The Python ad thin translation layer. The design and its guarantees are in [plugin-host-model.md](plugin-host-model.md). -**Size.** 74 files, +30,697 / −178, against the merge base. About 15,000 added lines are the +**Size.** 75 files, +30,833 / −178, against current `main`. About 15,000 added lines are the new plugin crate (including a 3,000-line lockfile and a generator), 5,600 are the API crate (3,500 of them the entity coverage validator), and 8,800 are in `src/`, of which roughly 6,200 -are tests in `plugin_host.rs`. Existing OCS code changes by **178 deleted lines in total**; +are tests in `plugin_host.rs`. Existing OCS code changes by **178 deleted lines in total** (151 of them outside docs, plugin and API); everything else is additive. ## Check it without a Mac @@ -54,11 +54,14 @@ Already run for you: | `fork-build.yml` (release build with the plugin staged) | Linux and Windows | 60 of 60 host tests on each; unsigned portable packages you can download and run | | Local | macOS | the same, plus the wasm check | -What has **not** been done: launching the GUI on Linux or Windows (the runners have no display), running -the whole `cargo test --lib` suite there, and building an AppImage or MSI that contains the plugin. Two -unrelated tests, `arc_grips_drive_center_start_and_end_but_not_midpoint` and `fonts_parse_and_resolve`, -fail on pristine `main` in the macOS environment used; they are not part of this change and I do not know -how they behave on Linux or Windows. +`main` now has its own `Tests` workflow (`cargo test --workspace --locked` on Linux), which will also run on +this pull request. Run locally on macOS against the merged tree with the same command and `LC_ALL=C` and +`--no-fail-fast`, the whole workspace gives **1,805 passed and 1 failed**. The one failure, +`scene::text::lff::tests::fonts_parse_and_resolve`, also fails on pristine `main` in that environment (it +needs font data) and is not part of this change; I expect it passes on the Linux runner but have not seen that. + +What has **not** been done: launching the GUI on Linux or Windows (the runners have no display), running the +whole workspace suite on Windows, and building an AppImage or MSI that contains the plugin. ## Reading order