Select Color: review cleanups

- Split ColorEditor::view into mode_row, slider_rows, field_view,
  hex_row and hex_field; output is unchanged.
- hex_string reuses config::rgb_to_hex, and parse_hex documents why it
  stays separate (it also accepts #RGB).
- ink_is_dark uses Color::into_rgba8 instead of rounding by hand.
- Remove four translation keys the old dialog used and nothing
  references any more, from the catalog and all 22 locales.
- Eyedropper: without a main window there is no screenshot to wait for,
  so leave the eyedropper; keep the magnifier inside small windows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013rGmDUNr1hUf4zo1X3dak8
This commit is contained in:
Claude committed 2026-10-12 19:21:38 +00:00
1 parent cc40722f70
commit fefd526c98
28 files changed
+147 -221

No files matched your search

-4
View File
@@ -1334,8 +1334,6 @@ common =
.dismiss = إغلاق
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = لا توجد ألوان حديثة بعد
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1343,9 +1341,7 @@ common =
.nearest-index-color = أقرب فهرس
.exact-index-match = تطابق تام مع الفهرس
.cad-color-index-aci-10-249 = فهرس ألوان ACI 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = المستخدمة مؤخرًا
.isometric-drafting = الرسم متساوي القياس
.f5-cycles-the-active-plane = يبدّل F5 المستوى النشط بالتتابع.
.units-5430a1 = { common.units }…
-4
View File
@@ -1321,8 +1321,6 @@ common =
.dismiss = Затваряне
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = Все още няма скорошни цветове
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1330,9 +1328,7 @@ common =
.nearest-index-color = Най-близък индекс
.exact-index-match = Точно съвпадение с индекс
.cad-color-index-aci-10-249 = ACI Цветови индекс 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = Последно използвани
.isometric-drafting = Изометрично чертане
.f5-cycles-the-active-plane = F5 превключва последователно активната равнина.
.units-5430a1 = { common.units }…
-4
View File
@@ -1321,8 +1321,6 @@ common =
.dismiss = Zavřít
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = Zatím žádné nedávné barvy
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1330,9 +1328,7 @@ common =
.nearest-index-color = Nejbližší index
.exact-index-match = Přesná shoda s indexem
.cad-color-index-aci-10-249 = Barevný index ACI 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = Nedávno použité
.isometric-drafting = Izometrické kreslení
.f5-cycles-the-active-plane = F5 cyklicky přepíná aktivní rovinu.
.units-5430a1 = { common.units }…
-4
View File
@@ -1322,8 +1322,6 @@ common =
.dismiss = Schließen
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = Noch keine zuletzt verwendeten Farben
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1331,9 +1329,7 @@ common =
.nearest-index-color = Nächster Index
.exact-index-match = Exakter Index-Treffer
.cad-color-index-aci-10-249 = ACI Farbindex 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = Zuletzt verwendet
.isometric-drafting = Isometrisches Zeichnen
.f5-cycles-the-active-plane = F5 wechselt die aktive Ebene der Reihe nach.
.units-5430a1 = { common.units }…
-4
View File
@@ -1323,8 +1323,6 @@ common =
.dismiss = Κλείσιμο
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = Δεν υπάρχουν ακόμη πρόσφατα χρώματα
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1332,9 +1330,7 @@ common =
.nearest-index-color = Πλησιέστερος δείκτης
.exact-index-match = Ακριβής αντιστοίχιση δείκτη
.cad-color-index-aci-10-249 = Δείκτης χρώματος ACI 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = Πρόσφατα χρησιμοποιημένα
.isometric-drafting = Ισομετρική σχεδίαση
.f5-cycles-the-active-plane = Το F5 εναλλάσσει το ενεργό επίπεδο.
.units-5430a1 = { common.units }…
-4
View File
@@ -1323,8 +1323,6 @@ common =
.dismiss = Dismiss
.value-8a8de8 = ?
.select-color-8dddf1 = Select Color...
.no-recent-colors-yet = No recent colors yet
.true-color-rgb = True Color RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = Index Color
.true-color = True Color
.standard-colors = Standard colors
@@ -1332,9 +1330,7 @@ common =
.nearest-index-color = Nearest index
.exact-index-match = Exact index match
.cad-color-index-aci-10-249 = CAD Color Index (ACI) 10–249
.color-family-shade-intensity = Color family → · Shade / intensity ↓
.grayscale-250-255 = Grayscale 250–255
.recently-used = Recently used
.isometric-drafting = Isometric drafting
.f5-cycles-the-active-plane = F5 cycles the active plane.
.units-5430a1 = Units…
-4
View File
@@ -1322,8 +1322,6 @@ common =
.dismiss = Cerrar
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = Aún no hay colores recientes
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1331,9 +1329,7 @@ common =
.nearest-index-color = Índice más cercano
.exact-index-match = Coincide con un índice
.cad-color-index-aci-10-249 = Índice de color ACI 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = Usados recientemente
.isometric-drafting = Dibujo isométrico
.f5-cycles-the-active-plane = F5 alterna el plano activo.
.units-5430a1 = { common.units }…
-4
View File
@@ -1321,8 +1321,6 @@ common =
.dismiss = Sulje
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = Ei vielä viimeksi käytettyjä värejä
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1330,9 +1328,7 @@ common =
.nearest-index-color = Lähin indeksi
.exact-index-match = Täsmälleen indeksiväri
.cad-color-index-aci-10-249 = ACI väriindeksi 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = Viimeksi käytetyt
.isometric-drafting = Isometrinen piirtäminen
.f5-cycles-the-active-plane = F5 vaihtaa aktiivista tasoa.
.units-5430a1 = { common.units }…
-4
View File
@@ -1322,8 +1322,6 @@ common =
.dismiss = Fermer
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = Aucune couleur récente
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1331,9 +1329,7 @@ common =
.nearest-index-color = Index le plus proche
.exact-index-match = Correspondance exacte d'index
.cad-color-index-aci-10-249 = ACI Indice de couleur 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = Utilisés récemment
.isometric-drafting = Dessin isométrique
.f5-cycles-the-active-plane = F5 fait défiler les plans actifs.
.units-5430a1 = { common.units }…
-4
View File
@@ -1310,8 +1310,6 @@ common =
.dismiss = बंद करें
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = अभी कोई हालिया रंग नहीं है
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1319,9 +1317,7 @@ common =
.nearest-index-color = निकटतम इंडेक्स
.exact-index-match = इंडेक्स से सटीक मेल
.cad-color-index-aci-10-249 = ACI रंग सूचकांक 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = हाल में उपयोग किए गए
.isometric-drafting = सममितीय आरेखन
.f5-cycles-the-active-plane = F5 सक्रिय तल को क्रम से बदलता है।
.units-5430a1 = { common.units }…
-4
View File
@@ -1321,8 +1321,6 @@ common =
.dismiss = Bezárás
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = Még nincsenek legutóbbi színek
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1330,9 +1328,7 @@ common =
.nearest-index-color = Legközelebbi index
.exact-index-match = Pontos indexegyezés
.cad-color-index-aci-10-249 = ACI színindex 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = Legutóbb használt
.isometric-drafting = Izometrikus rajzolás
.f5-cycles-the-active-plane = Az F5 váltja az aktív síkot.
.units-5430a1 = { common.units }…
-4
View File
@@ -1321,8 +1321,6 @@ common =
.dismiss = Chiudi
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = Nessun colore recente
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1330,9 +1328,7 @@ common =
.nearest-index-color = Indice più vicino
.exact-index-match = Corrispondenza esatta indice
.cad-color-index-aci-10-249 = ACI Indice colori 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = Usati di recente
.isometric-drafting = Disegno isometrico
.f5-cycles-the-active-plane = F5 alterna il piano attivo.
.units-5430a1 = { common.units }…
-4
View File
@@ -1312,8 +1312,6 @@ common =
.dismiss = 閉じる
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = 最近使った色はありません
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1321,9 +1319,7 @@ common =
.nearest-index-color = 最も近いインデックス
.exact-index-match = インデックスと完全一致
.cad-color-index-aci-10-249 = ACI カラーインデックス 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = 最近使用した色
.isometric-drafting = アイソメ図作成
.f5-cycles-the-active-plane = F5でアクティブな平面を順に切り替えます。
.units-5430a1 = { common.units }…
-4
View File
@@ -1321,8 +1321,6 @@ common =
.dismiss = 닫기
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = 최근 사용한 색상이 없습니다
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1330,9 +1328,7 @@ common =
.nearest-index-color = 가장 가까운 인덱스
.exact-index-match = 인덱스와 정확히 일치
.cad-color-index-aci-10-249 = ACI 컬러 인덱스 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = 최근 사용
.isometric-drafting = 등각 제도
.f5-cycles-the-active-plane = F5 키로 활성 평면을 순환 전환합니다.
.units-5430a1 = { common.units }…
-4
View File
@@ -1323,8 +1323,6 @@ common =
.dismiss = ປິດອອກ
.value-8a8de8 = ?
.select-color-8dddf1 = ເລືອກສີ...
.no-recent-colors-yet = ຍັງບໍ່ມີສີຫຼ້າສຸດ
.true-color-rgb = True Color RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = ສີດັດຊະນີ
.true-color = True Color
.standard-colors = ສີມາດຕະຖານ
@@ -1332,9 +1330,7 @@ common =
.nearest-index-color = ດັດຊະນີທີ່ໃກ້ທີ່ສຸດ
.exact-index-match = ກົງກັບດັດຊະນີພໍດີ
.cad-color-index-aci-10-249 = CAD Color Index (ACI) 10–249
.color-family-shade-intensity = ກຸ່ມສີ → · ລະດັບສີ / ຄວາມເຂັ້ມ ↓
.grayscale-250-255 = ລະດັບສີເທົາ 250–255
.recently-used = ໃຊ້ຫຼ້າສຸດ
.isometric-drafting = ການຂຽນແບບໄອໂຊເມຕຣິກ
.f5-cycles-the-active-plane = F5 ປ່ຽນລະນາບທີ່ໃຊ້ງານວຽນໄປ.
.units-5430a1 = ຫົວໜ່ວຍ…
-4
View File
@@ -1320,8 +1320,6 @@ common =
.dismiss = Sluiten
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = Nog geen recente kleuren
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1329,9 +1327,7 @@ common =
.nearest-index-color = Dichtstbijzijnde index
.exact-index-match = Exacte indexkleur
.cad-color-index-aci-10-249 = ACI Kleurindex 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = Recent gebruikt
.isometric-drafting = Isometrisch tekenen
.f5-cycles-the-active-plane = F5 wisselt het actieve vlak.
.units-5430a1 = { common.units }…
-4
View File
@@ -1321,8 +1321,6 @@ common =
.dismiss = Zamknij
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = Brak ostatnio używanych kolorów
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1330,9 +1328,7 @@ common =
.nearest-index-color = Najbliższy indeks
.exact-index-match = Dokładne dopasowanie indeksu
.cad-color-index-aci-10-249 = Indeks kolorów ACI 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = Ostatnio używane
.isometric-drafting = Rysowanie izometryczne
.f5-cycles-the-active-plane = F5 przełącza aktywną płaszczyznę.
.units-5430a1 = { common.units }…
-4
View File
@@ -1322,8 +1322,6 @@ common =
.dismiss = Fechar
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = Nenhuma cor recente ainda
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1331,9 +1329,7 @@ common =
.nearest-index-color = Índice mais próximo
.exact-index-match = Corresponde exatamente ao índice
.cad-color-index-aci-10-249 = Índice de cor ACI 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = Usados recentemente
.isometric-drafting = Desenho isométrico
.f5-cycles-the-active-plane = F5 alterna o plano ativo.
.units-5430a1 = { common.units }…
-4
View File
@@ -1325,8 +1325,6 @@ common =
.dismiss = Закрыть
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = Недавно использованных цветов пока нет
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1334,9 +1332,7 @@ common =
.nearest-index-color = Ближайший индекс
.exact-index-match = Точное совпадение с индексом
.cad-color-index-aci-10-249 = Индекс цвета ACI 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = Недавно использованные
.isometric-drafting = Изометрическое черчение
.f5-cycles-the-active-plane = F5 циклически переключает активную плоскость.
.units-5430a1 = { common.units }…
-4
View File
@@ -1308,8 +1308,6 @@ common =
.dismiss = Kapat
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = Henüz son kullanılan renk yok
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1317,9 +1315,7 @@ common =
.nearest-index-color = En yakın indeks
.exact-index-match = Tam indeks eşleşmesi
.cad-color-index-aci-10-249 = ACI renk dizini 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = Son kullanılanlar
.isometric-drafting = İzometrik çizim
.f5-cycles-the-active-plane = F5 etkin düzlemi sırayla değiştirir.
.units-5430a1 = { common.units }…
-4
View File
@@ -1309,8 +1309,6 @@ common =
.dismiss = 关闭
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = 尚无最近使用的颜色
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1318,9 +1316,7 @@ common =
.nearest-index-color = 最接近的索引色
.exact-index-match = 与索引色完全匹配
.cad-color-index-aci-10-249 = ACI 颜色索引 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = 最近使用
.isometric-drafting = 等轴测绘图
.f5-cycles-the-active-plane = F5 循环切换活动平面。
.units-5430a1 = { common.units }…
-4
View File
@@ -1321,8 +1321,6 @@ common =
.dismiss = 關閉
.value-8a8de8 = ?
.select-color-8dddf1 = { common.select-color }…
.no-recent-colors-yet = 尚無最近使用的顏色
.true-color-rgb = { common.true-color } RGB __ocs_fmt_0__, __ocs_fmt_1__, __ocs_fmt_2__
.index-color = { common.color } (ACI)
.true-color = { common.color } (RGB)
.standard-colors = { common.standard } · { common.color }
@@ -1330,9 +1328,7 @@ common =
.nearest-index-color = 最接近的索引色
.exact-index-match = 與索引色完全相符
.cad-color-index-aci-10-249 = ACI 顏色索引 10–249
.color-family-shade-intensity = { common.color-family } → · { common.shade } / { properties.intensity } ↓
.grayscale-250-255 = { common.grayscale } 250–255
.recently-used = 最近使用
.isometric-drafting = 等角製圖
.f5-cycles-the-active-plane = F5 循環切換作用中平面。
.units-5430a1 = { common.units }…