1b-agent/OneCAD
1
0 Fork 0
forked from 1b-agent/solidcraft-upstream
Code Pull Requests Activity

A hole on a face drills into the material, also in older designs (#950) (#952)

Browse Source 
* Hole matrix: placement, types, extents, edits and 0.9.0 designs, with today's failures listed

Each case checks the drill goes into the material, the bore sits on its axis, a blind hole stops
where it should, the removed volume against its analytic value, the face count and that every
body is still one closed valid solid. Failing cases are listed in tests/hole_matrix/known_failures.txt
as a ratchet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* A hole on a face drills into the material, also in older designs (#950)

Without a direction, solid.hole took the direction from any face whose infinite plane passed
within ten tolerances of the point, the last one found winning: the far side of a thin plate or a
face of another body at the same height could set it, and the wrong direction was saved. It now
uses the face nearest the point, against its outward normal (exact for planes, cylinders and
spheres, so holes on curved faces work without a direction). When a design is evaluated, a face
hole whose saved direction leaves the face it starts on is mirrored into it, so designs saved
with the wrong direction drill into the part.

Fixes #950.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Hole at a point on no face (a planar face's centroid outside it) keeps the plane it lies in

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Record the hole direction fix in the goldens and the action matrix baseline (#950)

Seeds 7, 21, 81 and 85 drill their holes straight into their faces now. In the action matrix,
holes on four faces that used to go the wrong way now build, and two whose correct direction
meets a cut the kernel refuses are marked failing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Goldens: seeds 7, 21 and 85 drill their holes straight in (#950)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
bherbruckandClaude Opus 5.5 authored and GitHub committed 2026-10-14 01:45:11 -04:00
1 parent 813bee8914
commit 1ff16cc72b
15 files changed
+1993 -30
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/hole_matrix/known_failures.txt
+1
View File
@@ -0,0 +1 @@
# Hole matrix cases that fail today (crates/engine/src/hole_matrix_tests.rs). A fix takes its case off.
tests/hole_matrix/old-0.9/mirror_bottom_blind.json
+189
View File
@@ -0,0 +1,189 @@
{
"features": [
{
"id": 1,
"name": "S",
"plane": {
"name": "XY",
"type": "origin"
},
"sketch": {
"constraints": [
{
"id": "k1",
"l": 0,
"type": "horizontal"
},
{
"id": "k2",
"l": 2,
"type": "horizontal"
},
{
"id": "k3",
"l": 1,
"type": "vertical"
},
{
"id": "k4",
"l": 3,
"type": "vertical"
},
{
"id": "k5",
"p": 0,
"q": 1,
"type": "coincident"
}
],
"counters": {
"k": 5,
"l": 4,
"p": 4
},
"curves": [
{
"a": 1,
"b": 2,
"construction": false,
"id": "l1",
"type": "line"
},
{
"a": 2,
"b": 3,
"construction": false,
"id": "l2",
"type": "line"
},
{
"a": 3,
"b": 4,
"construction": false,
"id": "l3",
"type": "line"
},
{
"a": 4,
"b": 1,
"construction": false,
"id": "l4",
"type": "line"
}
],
"points": [
{
"fixed": true,
"id": "origin",
"pos": [
0.0,
0.0
]
},
{
"fixed": false,
"id": "p1",
"pos": [
0.0,
0.0
]
},
{
"fixed": false,
"id": "p2",
"pos": [
40.0,
0.0
]
},
{
"fixed": false,
"id": "p3",
"pos": [
40.0,
30.0
]
},
{
"fixed": false,
"id": "p4",
"pos": [
0.0,
30.0
]
}
]
},
"suppressed": false,
"type": "sketch"
},
{
"body_names": [
"B"
],
"extent": {
"direction": "positive",
"distance": "20"
},
"id": 2,
"name": "Extrude1",
"operation": "new_body",
"param_names": [
"d1"
],
"profiles": {
"type": "all"
},
"sketch": 1,
"suppressed": false,
"type": "extrude"
},
{
"bodies": [
"B"
],
"features": [],
"id": 3,
"name": "Mirror1",
"plane": {
"name": "XY",
"type": "origin"
},
"suppressed": false,
"type": "mirror"
},
{
"depth": "10",
"diameter": "6",
"direction": [
-0.0,
0.0,
1.0
],
"face_names": [
"F2:top@F3.1"
],
"hole": {
"type": "simple"
},
"id": 4,
"name": "Hole1",
"param_names": [
"d2",
"d3"
],
"position": [
20.0,
15.0,
-20.0
],
"suppressed": false,
"type": "hole"
}
],
"format": "solidcraft/17",
"name": "mirror_bottom_blind",
"next_id": 5,
"params": [],
"units": "mm"
}
tests/hole_matrix/old-0.9/neighbour_top_blind.json
+323
View File
@@ -0,0 +1,323 @@
{
"features": [
{
"id": 1,
"name": "S",
"plane": {
"name": "XY",
"type": "origin"
},
"sketch": {
"constraints": [
{
"id": "k1",
"l": 0,
"type": "horizontal"
},
{
"id": "k2",
"l": 2,
"type": "horizontal"
},
{
"id": "k3",
"l": 1,
"type": "vertical"
},
{
"id": "k4",
"l": 3,
"type": "vertical"
},
{
"id": "k5",
"p": 0,
"q": 1,
"type": "coincident"
}
],
"counters": {
"k": 5,
"l": 4,
"p": 4
},
"curves": [
{
"a": 1,
"b": 2,
"construction": false,
"id": "l1",
"type": "line"
},
{
"a": 2,
"b": 3,
"construction": false,
"id": "l2",
"type": "line"
},
{
"a": 3,
"b": 4,
"construction": false,
"id": "l3",
"type": "line"
},
{
"a": 4,
"b": 1,
"construction": false,
"id": "l4",
"type": "line"
}
],
"points": [
{
"fixed": true,
"id": "origin",
"pos": [
0.0,
0.0
]
},
{
"fixed": false,
"id": "p1",
"pos": [
0.0,
0.0
]
},
{
"fixed": false,
"id": "p2",
"pos": [
40.0,
0.0
]
},
{
"fixed": false,
"id": "p3",
"pos": [
40.0,
30.0
]
},
{
"fixed": false,
"id": "p4",
"pos": [
0.0,
30.0
]
}
]
},
"suppressed": false,
"type": "sketch"
},
{
"body_names": [
"B"
],
"extent": {
"direction": "positive",
"distance": "20"
},
"id": 2,
"name": "Extrude1",
"operation": "new_body",
"param_names": [
"d1"
],
"profiles": {
"type": "all"
},
"sketch": 1,
"suppressed": false,
"type": "extrude"
},
{
"id": 3,
"name": "S2",
"plane": {
"plane": {
"origin": [
0.0,
0.0,
20.0
],
"x_dir": [
1.0,
0.0,
0.0
],
"y_dir": [
0.0,
1.0,
0.0
]
},
"type": "custom"
},
"sketch": {
"constraints": [
{
"id": "k1",
"l": 0,
"type": "horizontal"
},
{
"id": "k2",
"l": 2,
"type": "horizontal"
},
{
"id": "k3",
"l": 1,
"type": "vertical"
},
{
"id": "k4",
"l": 3,
"type": "vertical"
}
],
"counters": {
"k": 4,
"l": 4,
"p": 4
},
"curves": [
{
"a": 1,
"b": 2,
"construction": false,
"id": "l1",
"type": "line"
},
{
"a": 2,
"b": 3,
"construction": false,
"id": "l2",
"type": "line"
},
{
"a": 3,
"b": 4,
"construction": false,
"id": "l3",
"type": "line"
},
{
"a": 4,
"b": 1,
"construction": false,
"id": "l4",
"type": "line"
}
],
"points": [
{
"fixed": true,
"id": "origin",
"pos": [
0.0,
0.0
]
},
{
"fixed": false,
"id": "p1",
"pos": [
60.0,
0.0
]
},
{
"fixed": false,
"id": "p2",
"pos": [
80.0,
0.0
]
},
{
"fixed": false,
"id": "p3",
"pos": [
80.0,
30.0
]
},
{
"fixed": false,
"id": "p4",
"pos": [
60.0,
30.0
]
}
]
},
"suppressed": false,
"type": "sketch"
},
{
"body_names": [
"N"
],
"extent": {
"direction": "positive",
"distance": "20"
},
"id": 4,
"name": "Extrude2",
"operation": "new_body",
"param_names": [
"d2"
],
"profiles": {
"type": "all"
},
"sketch": 3,
"suppressed": false,
"type": "extrude"
},
{
"depth": "10",
"diameter": "6",
"direction": [
-0.0,
0.0,
1.0
],
"face_names": [
"F2:top"
],
"hole": {
"type": "simple"
},
"id": 5,
"name": "Hole1",
"param_names": [
"d3",
"d4"
],
"position": [
20.0,
15.0,
20.0
],
"suppressed": false,
"type": "hole"
}
],
"format": "solidcraft/17",
"name": "neighbour_top_blind",
"next_id": 6,
"params": [],
"units": "mm"
}
tests/hole_matrix/old-0.9/points_top_blind.json
+236
View File
@@ -0,0 +1,236 @@
{
"features": [
{
"id": 1,
"name": "S",
"plane": {
"name": "XY",
"type": "origin"
},
"sketch": {
"constraints": [
{
"id": "k1",
"l": 0,
"type": "horizontal"
},
{
"id": "k2",
"l": 2,
"type": "horizontal"
},
{
"id": "k3",
"l": 1,
"type": "vertical"
},
{
"id": "k4",
"l": 3,
"type": "vertical"
},
{
"id": "k5",
"p": 0,
"q": 1,
"type": "coincident"
}
],
"counters": {
"k": 5,
"l": 4,
"p": 4
},
"curves": [
{
"a": 1,
"b": 2,
"construction": false,
"id": "l1",
"type": "line"
},
{
"a": 2,
"b": 3,
"construction": false,
"id": "l2",
"type": "line"
},
{
"a": 3,
"b": 4,
"construction": false,
"id": "l3",
"type": "line"
},
{
"a": 4,
"b": 1,
"construction": false,
"id": "l4",
"type": "line"
}
],
"points": [
{
"fixed": true,
"id": "origin",
"pos": [
0.0,
0.0
]
},
{
"fixed": false,
"id": "p1",
"pos": [
0.0,
0.0
]
},
{
"fixed": false,
"id": "p2",
"pos": [
40.0,
0.0
]
},
{
"fixed": false,
"id": "p3",
"pos": [
40.0,
30.0
]
},
{
"fixed": false,
"id": "p4",
"pos": [
0.0,
30.0
]
}
]
},
"suppressed": false,
"type": "sketch"
},
{
"body_names": [
"B"
],
"extent": {
"direction": "positive",
"distance": "20"
},
"id": 2,
"name": "Extrude1",
"operation": "new_body",
"param_names": [
"d1"
],
"profiles": {
"type": "all"
},
"sketch": 1,
"suppressed": false,
"type": "extrude"
},
{
"id": 3,
"name": "P",
"plane": {
"plane": {
"origin": [
0.0,
0.0,
20.0
],
"x_dir": [
1.0,
0.0,
0.0
],
"y_dir": [
0.0,
1.0,
0.0
]
},
"type": "custom"
},
"sketch": {
"constraints": [],
"counters": {},
"curves": [],
"points": [
{
"fixed": true,
"id": "origin",
"pos": [
0.0,
0.0
]
},
{
"fixed": false,
"id": "q0",
"pos": [
10.0,
10.0
]
},
{
"fixed": false,
"id": "q1",
"pos": [
30.0,
20.0
]
}
]
},
"suppressed": false,
"type": "sketch"
},
{
"depth": "10",
"diameter": "6",
"direction": [
-0.0,
-0.0,
-1.0
],
"hole": {
"type": "simple"
},
"id": 4,
"name": "Hole1",
"param_names": [
"d2",
"d3"
],
"points": {
"ids": [
"q0",
"q1"
],
"sketch": 3
},
"position": [
10.0,
10.0,
20.0
],
"suppressed": false,
"type": "hole"
}
],
"format": "solidcraft/17",
"name": "points_top_blind",
"next_id": 5,
"params": [],
"units": "mm"
}
tests/hole_matrix/old-0.9/thin_plate_bottom_blind.json
+175
View File
@@ -0,0 +1,175 @@
{
"features": [
{
"id": 1,
"name": "S",
"plane": {
"name": "XY",
"type": "origin"
},
"sketch": {
"constraints": [
{
"id": "k1",
"l": 0,
"type": "horizontal"
},
{
"id": "k2",
"l": 2,
"type": "horizontal"
},
{
"id": "k3",
"l": 1,
"type": "vertical"
},
{
"id": "k4",
"l": 3,
"type": "vertical"
},
{
"id": "k5",
"p": 0,
"q": 1,
"type": "coincident"
}
],
"counters": {
"k": 5,
"l": 4,
"p": 4
},
"curves": [
{
"a": 1,
"b": 2,
"construction": false,
"id": "l1",
"type": "line"
},
{
"a": 2,
"b": 3,
"construction": false,
"id": "l2",
"type": "line"
},
{
"a": 3,
"b": 4,
"construction": false,
"id": "l3",
"type": "line"
},
{
"a": 4,
"b": 1,
"construction": false,
"id": "l4",
"type": "line"
}
],
"points": [
{
"fixed": true,
"id": "origin",
"pos": [
0.0,
0.0
]
},
{
"fixed": false,
"id": "p1",
"pos": [
0.0,
0.0
]
},
{
"fixed": false,
"id": "p2",
"pos": [
150.0,
0.0
]
},
{
"fixed": false,
"id": "p3",
"pos": [
150.0,
100.0
]
},
{
"fixed": false,
"id": "p4",
"pos": [
0.0,
100.0
]
}
]
},
"suppressed": false,
"type": "sketch"
},
{
"body_names": [
"B"
],
"extent": {
"direction": "positive",
"distance": "1.5"
},
"id": 2,
"name": "Extrude1",
"operation": "new_body",
"param_names": [
"d1"
],
"profiles": {
"type": "all"
},
"sketch": 1,
"suppressed": false,
"type": "extrude"
},
{
"depth": "1",
"diameter": "6",
"direction": [
-0.0,
-0.0,
-1.0
],
"face_names": [
"F2:start"
],
"hole": {
"type": "simple"
},
"id": 3,
"name": "Hole1",
"param_names": [
"d2",
"d3"
],
"position": [
50.0,
50.0,
0.0
],
"suppressed": false,
"type": "hole"
}
],
"format": "solidcraft/17",
"name": "thin_plate_bottom_blind",
"next_id": 4,
"params": [],
"units": "mm"
}
tests/hole_matrix/old-0.9/top_blind.json
+175
View File
@@ -0,0 +1,175 @@
{
"features": [
{
"id": 1,
"name": "S",
"plane": {
"name": "XY",
"type": "origin"
},
"sketch": {
"constraints": [
{
"id": "k1",
"l": 0,
"type": "horizontal"
},
{
"id": "k2",
"l": 2,
"type": "horizontal"
},
{
"id": "k3",
"l": 1,
"type": "vertical"
},
{
"id": "k4",
"l": 3,
"type": "vertical"
},
{
"id": "k5",
"p": 0,
"q": 1,
"type": "coincident"
}
],
"counters": {
"k": 5,
"l": 4,
"p": 4
},
"curves": [
{
"a": 1,
"b": 2,
"construction": false,
"id": "l1",
"type": "line"
},
{
"a": 2,
"b": 3,
"construction": false,
"id": "l2",
"type": "line"
},
{
"a": 3,
"b": 4,
"construction": false,
"id": "l3",
"type": "line"
},
{
"a": 4,
"b": 1,
"construction": false,
"id": "l4",
"type": "line"
}
],
"points": [
{
"fixed": true,
"id": "origin",
"pos": [
0.0,
0.0
]
},
{
"fixed": false,
"id": "p1",
"pos": [
0.0,
0.0
]
},
{
"fixed": false,
"id": "p2",
"pos": [
40.0,
0.0
]
},
{
"fixed": false,
"id": "p3",
"pos": [
40.0,
30.0
]
},
{
"fixed": false,
"id": "p4",
"pos": [
0.0,
30.0
]
}
]
},
"suppressed": false,
"type": "sketch"
},
{
"body_names": [
"B"
],
"extent": {
"direction": "positive",
"distance": "20"
},
"id": 2,
"name": "Extrude1",
"operation": "new_body",
"param_names": [
"d1"
],
"profiles": {
"type": "all"
},
"sketch": 1,
"suppressed": false,
"type": "extrude"
},
{
"depth": "10",
"diameter": "6",
"direction": [
-0.0,
-0.0,
-1.0
],
"face_names": [
"F2:top"
],
"hole": {
"type": "simple"
},
"id": 3,
"name": "Hole1",
"param_names": [
"d2",
"d3"
],
"position": [
20.0,
15.0,
20.0
],
"suppressed": false,
"type": "hole"
}
],
"format": "solidcraft/17",
"name": "top_blind",
"next_id": 4,
"params": [],
"units": "mm"
}