One walk over a feature's references (2/3, #876) (#988)

Part 2 of #876: one walk over the references a feature holds (the sketches it's built from, the features it names, the bodies it works on) replaces three hand-written matches, with a golden record covering every variant.

crates/engine/src/cmd/clipboard.rs

@@ -391,4 +391,25 @@ mod tests {
         assert_eq!(m["body_count"], 2, "{m}");
         assert!((volume(&mut s) - 2.0 * one).abs() < 1e-6, "both blocks are rounded: {m}");
     }
+
+    /// A pasted coil that joins a body made by an earlier copy joins that copy, not the original.
+    #[test]
+    fn a_pasted_coil_joins_the_pasted_body() {
+        let mut s = Session::default();
+        run(&mut s, "solid.box", json!({"length": 30, "width": 30, "height": 5, "name": "Base", "body_name": "Plate"}));
+        run(
+            &mut s,
+            "solid.coil",
+            json!({"diameter": 16, "pitch": 6, "revolutions": 3, "section_size": 2, "base": [15, 15, 5], "operation": "join", "targets": ["Plate"], "name": "Spring"}),
+        );
+        run(&mut s, "timeline.copy", json!({"features": ["Base", "Spring"]}));
+        let r = run(&mut s, "timeline.paste", json!({"translate": [50, 0, 0]}));
+        assert_eq!(r["errors"].as_array().map(Vec::len), Some(0), "{r}");
+        let spring = r["pasted"][1]["name"].as_str().unwrap_or_default().to_string();
+        let def = run(&mut s, "timeline.inspect", json!({"feature": spring}));
+        assert_eq!(def["definition"]["targets"], json!(["Plate (copy)"]), "{def}");
+        let st = s.world_state();
+        let v = |name: &str| solidcraft_kernel::measure(&st.body(name).unwrap().body).unwrap().volume;
+        assert!((v("Plate") - v("Plate (copy)")).abs() < 1e-6, "each plate carries one spring: {} vs {}", v("Plate"), v("Plate (copy)"));
+    }
 }

crates/engine/src/cmd/surface.rs

@@ -661,6 +661,25 @@ mod tests {
         assert_eq!(s.doc.features.len(), before, "a planned command changed the design");
     }
 
+    /// A trim keeps its construction plane when the plane is renamed.
+    #[test]
+    fn renaming_a_plane_keeps_a_surface_trim_on_it() {
+        let mut s = Session::default();
+        run(&mut s, "sketch.create", json!({"plane": "XY", "name": "S"}));
+        run(&mut s, "sketch.rectangle.two_point", json!({"p0": [0, 0], "p1": [40, 20]}));
+        run(&mut s, "sketch.finish", json!({}));
+        run(&mut s, "surface.patch", json!({"sketch": "S", "body_name": "Sheet"}));
+        run(&mut s, "construct.plane.offset", json!({"base": "YZ", "offset": 25, "name": "Cut"}));
+        run(&mut s, "surface.trim", json!({"body": "Sheet", "plane": "Cut", "keep": [10, 10, 0], "name": "Trim"}));
+        let trimmed = area(&s, "Sheet");
+        run(&mut s, "timeline.rename", json!({"feature": "Cut", "name": "Cutter"}));
+        assert!(s.model.results.iter().all(|r| r.error.is_none()), "the trim still finds its plane");
+        let def = run(&mut s, "timeline.inspect", json!({"feature": "Trim"}));
+        assert_eq!(def["definition"]["plane"]["name"], "Cutter", "{def}");
+        assert!((area(&s, "Sheet") - trimmed).abs() < 1e-6, "{} vs {trimmed}", area(&s, "Sheet"));
+        assert!(trimmed < 40.0 * 20.0 * 0.9, "the sheet is trimmed: {trimmed}");
+    }
+
     /// A rectangle patched, trimmed by a plane and thickened; a box's open top patched; a rim
     /// that is not planar patched.
     #[test]