* claim: #1801 * Insert SVG: the file picker opens on SVG files (#1801) Every Open went through one host picker whose filters start with designs, CAD files and meshes, so Insert SVG (and Insert DXF) in a sketch opened on STEP, IGES and meshes, and the SVG file had to be found under another filter. The host's pick_open now takes the extensions the command reads and offers them as the picker's first, default filter. Insert SVG and Insert DXF pass their type; every other Open passes none and keeps the list it had. The browser host ignores them (it shows its own file panel). --------- Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com>
This commit is contained in:
1 parent
a6ca2e8ca1
commit
c599238653
7 files changed
+46
-14
No files matched your search
@@ -254,7 +254,9 @@ impl Default for UiState {
|
||||
/// Host services injected by the app so this crate stays portable.
|
||||
#[derive(Default)]
|
||||
pub struct Services {
|
||||
pub pick_open: Option<Box<dyn Fn() -> FilePickerFuture>>,
|
||||
/// Ask for a file to open. The extensions are the file type the command reads, offered as
|
||||
/// the picker's first filter (`&[]`: designs, CAD files and meshes, #1801).
|
||||
pub pick_open: Option<Box<dyn Fn(&[&str]) -> FilePickerFuture>>,
|
||||
pub pick_save: Option<Box<dyn Fn(&str, &[&str]) -> FilePickerFuture>>,
|
||||
/// Open a dialog asking for a program (a slicer); `None` when the host has no such dialog.
|
||||
pub pick_program: Option<Box<dyn Fn() -> FilePickerFuture>>,
|
||||
@@ -736,8 +738,8 @@ impl SolveApp {
|
||||
dim_view::cancel();
|
||||
self.tool = None;
|
||||
self.home.open = false;
|
||||
if matches!(id, "sketch.insert_dxf" | "sketch.insert_svg") {
|
||||
self.pick_open_command(id, json!({}));
|
||||
if let Some(ext) = id.strip_prefix("sketch.insert_").filter(|e| matches!(*e, "dxf" | "svg")) {
|
||||
self.pick_open_command(id, json!({}), &[ext]);
|
||||
return;
|
||||
}
|
||||
if id == "component.insert_design" {
|
||||
|
||||
Reference in new issue
Block a user