bherbruckandClaude Opus 5.5
15b5b51bf5
A section stayed on with nothing in the browser to switch it off; only the viewport's context menu had Remove Section. While there is one, the browser now has an Analysis folder listing it. Its eye (and the folder's) hides the section and shows it again on the same plane; a double-click or Edit Section Analysis opens the dialog, and Delete removes it. Browser rows with an eye publish an `eye:<label>` handle for automation. Fixes #822 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
86 lines
3.1 KiB
Rust
86 lines
3.1 KiB
Rust
//! Section Analysis in the browser (#822): an Analysis folder lists it with an eye to hide and
|
|
//! show it, and its menu edits or deletes it.
|
|
|
|
use egui::pos2;
|
|
use serde_json::json;
|
|
|
|
use crate::context_menu::{self, Target};
|
|
use crate::scenario::Harness;
|
|
|
|
fn harness() -> Harness {
|
|
let mut h = Harness::new();
|
|
h.app.home.open = false;
|
|
h.app.ui.show_browser = true;
|
|
h.frames(3);
|
|
h
|
|
}
|
|
|
|
fn click(h: &mut Harness, handle: &str) {
|
|
assert!(crate::scenario::handle_at(handle).is_some(), "{handle} is not drawn: {:?}", crate::scenario::handles(""));
|
|
h.step(&json!({"click": {"handle": handle}})).unwrap();
|
|
h.frames(3);
|
|
}
|
|
|
|
fn menu(h: &mut Harness, label: &str) {
|
|
let items = context_menu::items(&h.app, &Target::Section);
|
|
let item = items.iter().find(|i| i.label == label).unwrap_or_else(|| panic!("no {label} in {items:?}")).clone();
|
|
context_menu::run_item(&mut h.app, &item, pos2(0.0, 0.0));
|
|
h.frames(3);
|
|
}
|
|
|
|
#[test]
|
|
fn no_analysis_folder_without_a_section() {
|
|
let h = harness();
|
|
assert!(crate::scenario::handle_at("row:Analysis").is_none());
|
|
assert!(crate::scenario::handle_at("row:Section Analysis").is_none());
|
|
drop(h);
|
|
}
|
|
|
|
#[test]
|
|
fn the_eye_hides_and_shows_the_section_and_delete_removes_it() {
|
|
let mut h = harness();
|
|
h.app.run("inspect.section", json!({"plane": "XZ", "offset": 15})).unwrap();
|
|
h.frames(3);
|
|
let section = h.app.session.section.expect("a section");
|
|
assert!(crate::scenario::handle_at("row:Section Analysis").is_some(), "the section is listed under Analysis");
|
|
|
|
click(&mut h, "eye:Section Analysis");
|
|
assert_eq!(h.app.session.section, None, "the eye turns the section off");
|
|
assert!(crate::scenario::handle_at("row:Section Analysis").is_some(), "a hidden section stays listed");
|
|
|
|
click(&mut h, "eye:Section Analysis");
|
|
let back = h.app.session.section.expect("the eye turns it back on");
|
|
assert!((back.0 - section.0).len() < 1e-9 && (back.1 - section.1).len() < 1e-9, "the same plane: {back:?} vs {section:?}");
|
|
|
|
// The folder's eye does the same.
|
|
click(&mut h, "eye:Analysis");
|
|
assert_eq!(h.app.session.section, None);
|
|
menu(&mut h, "Show/Hide");
|
|
assert!(h.app.session.section.is_some(), "Show/Hide in the menu brings it back");
|
|
|
|
menu(&mut h, "Delete");
|
|
assert_eq!(h.app.session.section, None);
|
|
assert!(h.app.tree.hidden_section.is_none());
|
|
assert!(crate::scenario::handle_at("row:Section Analysis").is_none(), "a deleted section leaves the browser");
|
|
}
|
|
|
|
#[test]
|
|
fn deleting_a_hidden_section_forgets_it() {
|
|
let mut h = harness();
|
|
h.app.run("inspect.section", json!({"plane": "XY", "offset": 2})).unwrap();
|
|
h.frames(3);
|
|
click(&mut h, "eye:Section Analysis");
|
|
menu(&mut h, "Delete");
|
|
assert!(h.app.session.section.is_none() && h.app.tree.hidden_section.is_none());
|
|
assert!(crate::scenario::handle_at("row:Analysis").is_none());
|
|
}
|
|
|
|
#[test]
|
|
fn edit_opens_the_section_dialog() {
|
|
let mut h = harness();
|
|
h.app.run("inspect.section", json!({"plane": "YZ"})).unwrap();
|
|
h.frames(3);
|
|
menu(&mut h, "Edit Section Analysis");
|
|
assert!(h.app.dialog.is_some(), "the Section Analysis dialog opens");
|
|
}
|