v1.0.21

src/routes/api/containers/check-updates/+server.ts

@@ -4,6 +4,7 @@ import { authorize } from '$lib/server/authorize';
 import { listContainers, inspectContainer, checkImageUpdateAvailable } from '$lib/server/docker';
 import { clearPendingContainerUpdates, addPendingContainerUpdate } from '$lib/server/db';
 import { isSystemContainer } from '$lib/server/scheduler/tasks/update-utils';
+import { createJobResponse } from '$lib/server/sse';
 
 export interface UpdateCheckResult {
 	containerId: string;
@@ -19,9 +20,9 @@ export interface UpdateCheckResult {
 
 /**
  * Check all containers for available image updates.
- * Returns all results at once after checking in parallel.
+ * Returns progress events during checking, final result when done.
  */
-export const POST: RequestHandler = async ({ url, cookies }) => {
+export const POST: RequestHandler = async ({ url, cookies, request }) => {
 	const auth = await authorize(cookies);
 
 	const envId = url.searchParams.get('env');
@@ -32,21 +33,21 @@ export const POST: RequestHandler = async ({ url, cookies }) => {
 		return json({ error: 'Permission denied' }, { status: 403 });
 	}
 
-	try {
+	return createJobResponse(async (send) => {
 		// Clear existing pending updates for this environment before checking
 		if (envIdNum) {
 			await clearPendingContainerUpdates(envIdNum);
 		}
 
 		const allContainers = await listContainers(true, envIdNum);
-
-		// Include all containers (system containers get flagged, not filtered)
 		const containers = allContainers;
 
+		send('progress', { checked: 0, total: containers.length });
+
 		// Check container for updates
+		let checked = 0;
 		const checkContainer = async (container: typeof containers[0]): Promise<UpdateCheckResult> => {
 			try {
-				// Get container's image name from config
 				const inspectData = await inspectContainer(container.id, envIdNum) as any;
 				const imageName = inspectData.Config?.Image;
 				const currentImageId = inspectData.Image;
@@ -62,7 +63,6 @@ export const POST: RequestHandler = async ({ url, cookies }) => {
 					};
 				}
 
-				// Use shared update detection function
 				const result = await checkImageUpdateAvailable(imageName, currentImageId, envIdNum);
 
 				return {
@@ -88,13 +88,23 @@ export const POST: RequestHandler = async ({ url, cookies }) => {
 			}
 		};
 
-		// Check all containers in parallel
-		const results = await Promise.all(containers.map(checkContainer));
+		// Sliding window concurrency limit to avoid DNS threadpool saturation (#676).
+		const CONCURRENCY = 20;
+		const results: UpdateCheckResult[] = new Array(containers.length);
+		let next = 0;
+		async function runNext(): Promise<void> {
+			while (next < containers.length) {
+				const idx = next++;
+				results[idx] = await checkContainer(containers[idx]);
+				checked++;
+				send('progress', { checked, total: containers.length });
+			}
+		}
+		await Promise.all(Array.from({ length: Math.min(CONCURRENCY, containers.length) }, () => runNext()));
 
 		const updatesFound = results.filter(r => r.hasUpdate).length;
 
 		// Save containers with updates to the database for persistence
-		// Skip system containers (Dockhand/Hawser) - they use their own update paths
 		if (envIdNum) {
 			for (const result of results) {
 				if (result.hasUpdate && !result.systemContainer) {
@@ -108,13 +118,10 @@ export const POST: RequestHandler = async ({ url, cookies }) => {
 			}
 		}
 
-		return json({
+		send('result', {
 			total: containers.length,
 			updatesFound,
 			results
 		});
-	} catch (error: any) {
-		console.error('Error checking for updates:', error);
-		return json({ error: 'Failed to check for updates', details: error.message }, { status: 500 });
-	}
+	}, request);
 };