Files
doktainer-upstream/tests/backend/database-session-security.test.ts
KodekaTeam 0bd696d37f feat(auth): add session history retention and lifecycle updates
- Add daily session history cleanup with a 180-day retention period
- Run cleanup on startup and every 24 hours in batches of up to 1,000 sessions
- Add tests for session retention and derived session status
- Allow viewers to manage their own sessions while preserving global access for super admins
- Prevent the current browser session from being revoked through session management
- Derive active, expired, and revoked status without writing during list requests
- Count only active sessions toward the 20-session per-user limit
- Remove unused session event queries and payloads from the session listing endpoint
- Update the session management UI for the revised access and revocation policies
2026-09-13 10:24:49 +07:00

280 lines
7.6 KiB
TypeScript

import assert from "node:assert/strict";
import { readFileSync } from "node:fs";
import test from "node:test";
import {
enforceBrowserMutationProtection,
} from "../../src/server/middleware/auth";
import {
canRevokeManagedSession,
getManagedSessionStatus,
getSessionCookieName,
hashSessionToken,
normalizeSessionUserAgent,
} from "../../src/server/services/auth-session.service";
function createReplyRecorder() {
return {
statusCode: 200,
payload: undefined as unknown,
status(code: number) {
this.statusCode = code;
return this;
},
send(payload: unknown) {
this.payload = payload;
return this;
},
};
}
test("session tokens are stored as deterministic hashes", () => {
const rawToken = "raw-session-token";
const tokenHash = hashSessionToken(rawToken);
assert.equal(tokenHash.length, 64);
assert.equal(tokenHash, hashSessionToken(rawToken));
assert.notEqual(tokenHash, rawToken);
});
test("production uses a host-bound session cookie name", () => {
assert.equal(
getSessionCookieName({ NODE_ENV: "production" } as NodeJS.ProcessEnv),
"__Host-doktainer_session",
);
assert.equal(
getSessionCookieName({ NODE_ENV: "development" } as NodeJS.ProcessEnv),
"doktainer_session",
);
});
test("session user agents drop control characters and remain bounded", () => {
const normalized = normalizeSessionUserAgent(`Browser\n${"x".repeat(600)}`);
assert.equal(normalized?.includes("\n"), false);
assert.equal(normalized?.length, 512);
});
test("browser mutation protection requires the application header", () => {
const reply = createReplyRecorder();
const allowed = enforceBrowserMutationProtection(
{ method: "POST", headers: {} } as never,
reply as never,
);
assert.equal(allowed, false);
assert.equal(reply.statusCode, 403);
});
test("browser mutation protection rejects cross-site requests", () => {
const reply = createReplyRecorder();
const allowed = enforceBrowserMutationProtection(
{
method: "DELETE",
headers: {
"x-doktainer-request": "1",
"sec-fetch-site": "cross-site",
},
} as never,
reply as never,
);
assert.equal(allowed, false);
assert.equal(reply.statusCode, 403);
});
test("safe methods and verified same-origin mutations are accepted", () => {
assert.equal(
enforceBrowserMutationProtection(
{ method: "GET", headers: {} } as never,
createReplyRecorder() as never,
),
true,
);
assert.equal(
enforceBrowserMutationProtection(
{
method: "PATCH",
headers: {
"x-doktainer-request": "1",
"sec-fetch-site": "same-origin",
origin: "http://localhost:3000",
},
} as never,
createReplyRecorder() as never,
),
true,
);
});
test("browser-confirmed same-origin mutations use the active origin without env configuration", () => {
const allowed = enforceBrowserMutationProtection(
{
method: "POST",
protocol: "http",
headers: {
host: "127.0.0.1:4000",
origin: "https://panel.example.com",
"sec-fetch-site": "same-origin",
"x-doktainer-request": "1",
},
} as never,
createReplyRecorder() as never,
{} as NodeJS.ProcessEnv,
);
assert.equal(allowed, true);
});
test("verified mutations accept the effective custom-domain request origin", () => {
const allowed = enforceBrowserMutationProtection(
{
method: "POST",
protocol: "https",
headers: {
host: "panel.example.com",
origin: "https://panel.example.com",
"sec-fetch-site": "same-site",
"x-doktainer-request": "1",
},
} as never,
createReplyRecorder() as never,
{
FRONTEND_URL: "http://localhost:3000",
TRUST_PROXY: "false",
} as NodeJS.ProcessEnv,
);
assert.equal(allowed, true);
});
test("forwarded custom-domain origin is trusted only behind an enabled proxy", () => {
const request = {
method: "POST",
protocol: "http",
headers: {
host: "127.0.0.1:4000",
origin: "https://panel.example.com",
"sec-fetch-site": "same-site",
"x-doktainer-request": "1",
"x-forwarded-host": "panel.example.com",
"x-forwarded-proto": "https",
},
} as never;
assert.equal(
enforceBrowserMutationProtection(
request,
createReplyRecorder() as never,
{ TRUST_PROXY: "true" } as NodeJS.ProcessEnv,
),
true,
);
const untrustedReply = createReplyRecorder();
assert.equal(
enforceBrowserMutationProtection(
request,
untrustedReply as never,
{ TRUST_PROXY: "false" } as NodeJS.ProcessEnv,
),
false,
);
assert.equal(untrustedReply.statusCode, 403);
});
test("only owners and super admins can revoke a managed login session", () => {
assert.equal(
canRevokeManagedSession({
actorUserId: "operator-1",
actorRole: "OPERATOR",
targetUserId: "user-2",
currentSessionId: "session-1",
targetSessionId: "session-2",
}),
false,
);
assert.equal(
canRevokeManagedSession({
actorUserId: "operator-1",
actorRole: "OPERATOR",
targetUserId: "operator-1",
currentSessionId: "session-1",
targetSessionId: "session-2",
}),
true,
);
assert.equal(
canRevokeManagedSession({
actorUserId: "admin-1",
actorRole: "SUPER_ADMIN",
targetUserId: "user-2",
currentSessionId: "session-1",
targetSessionId: "session-2",
}),
true,
);
assert.equal(
canRevokeManagedSession({
actorUserId: "admin-1",
actorRole: "SUPER_ADMIN",
targetUserId: "admin-1",
currentSessionId: "session-1",
targetSessionId: "session-1",
}),
false,
);
});
test("session status is derived without persisting expiry from list requests", () => {
const now = new Date("2026-09-12T12:00:00.000Z");
const activeSession = {
revokedAt: null,
revokeReason: null,
idleExpiresAt: new Date("2026-09-12T13:00:00.000Z"),
absoluteExpiresAt: new Date("2026-09-13T12:00:00.000Z"),
};
assert.equal(getManagedSessionStatus(activeSession, now), "active");
assert.equal(
getManagedSessionStatus(
{ ...activeSession, idleExpiresAt: new Date("2026-09-12T11:59:59.000Z") },
now,
),
"expired",
);
assert.equal(
getManagedSessionStatus(
{
...activeSession,
revokedAt: new Date("2026-09-12T10:00:00.000Z"),
revokeReason: "USER_REVOKED",
},
now,
),
"revoked",
);
});
test("session management is a dedicated protected page before Users and RBAC", () => {
const navigation = readFileSync("src/lib/navigation.ts", "utf8");
const permissions = readFileSync("src/lib/permissions.ts", "utf8");
const dashboard = readFileSync("src/app/page.tsx", "utf8");
const page = readFileSync("src/app/sessions/page.tsx", "utf8");
const routes = readFileSync("src/server/routes/auth.ts", "utf8");
assert.ok(navigation.indexOf('href: "/sessions"') < navigation.indexOf('href: "/users"'));
assert.match(permissions, /"\/sessions": "VIEWER"/);
assert.doesNotMatch(dashboard, /LoginSessionsPanel/);
assert.match(page, /route="\/sessions"/);
assert.match(page, /All statuses/);
assert.match(page, /All users/);
assert.match(routes, /app\.get\("\/sessions", \{ preHandler: \[requireRole\("VIEWER"\)\]/);
assert.match(routes, /"\/sessions\/:sessionId",\s+\{ preHandler: \[requireRole\("VIEWER"\)\] \}/);
assert.match(routes, /A browser login session is required/);
assert.doesNotMatch(routes, /expiredSessions/);
assert.doesNotMatch(routes, /events:\s*\{/);
assert.match(routes, /The current session cannot be revoked/);
assert.match(page, /session\.current \? null/);
});