6ad391fd75
* Chamfer: refuse a result that grew a convex edge's part (or shrank a concave one's) A chamfer of a curved edge that runs off a face it skims (robustness seed 57's ball rim) built a part bigger than before. Checked from the two faces' normals at the edge; rounds and unclear angles are left to the wedge bound. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Action matrix: the sheet metal tray's relief corners refuse a 0.25 mm chamfer Each is a 2.5 mm concave edge (the corner of a corner relief, between two planes at right angles): a chamfer there fills at most 0.25²/2 × 2.5 = 0.08 mm³. What was built took 0.95 mm³ away; the chamfer guard now refuses it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Robustness goldens: seed 57's wrong-way chamfer is now refused (#1390) On main with #391, seed 57's chamfer grew the part; this refuses it, so the run goes on to its later steps and ends ok. --------- Co-authored-by: Phanoob <phanoob@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
54 lines
2.6 KiB
Rust
54 lines
2.6 KiB
Rust
use solidcraft_geom::{Loop2, Plane, Region2, Seg2, Vec2, Vec3};
|
|
|
|
use crate::*;
|
|
|
|
/// Robustness seed 57's part: a block with an arc side, a ball cut from the edge of its back
|
|
/// face, just touching its bottom face.
|
|
fn block_with_ball_cut() -> Body {
|
|
let p = Vec2::new;
|
|
let line = |a: Vec2, b: Vec2| Seg2::Line { a, b };
|
|
let (c, r) = (p(24.0625, 11.25), 26.5625);
|
|
let start = (p(0.0, 22.5) - c).angle();
|
|
let sweep = ((p(0.0, 0.0) - c).angle() - start).rem_euclid(std::f64::consts::TAU);
|
|
let segs = vec![
|
|
line(p(0.0, 0.0), p(47.5, 0.0)),
|
|
line(p(47.5, 0.0), p(47.5, 22.5)),
|
|
line(p(47.5, 22.5), p(27.5, 22.5)),
|
|
line(p(27.5, 22.5), p(27.5, 12.5)),
|
|
line(p(27.5, 12.5), p(15.0, 12.5)),
|
|
line(p(15.0, 12.5), p(15.0, 22.5)),
|
|
line(p(15.0, 22.5), p(0.0, 22.5)),
|
|
Seg2::Arc { center: c, radius: r, start, sweep },
|
|
];
|
|
let block = crate::extrude(&Plane::XY, &[Region2 { outer: Loop2 { segs }, holes: vec![] }], 0.0, 17.5).unwrap().remove(0);
|
|
let ball = crate::sphere(Vec3::new(2.5, 22.5, 5.0), 5.0).unwrap();
|
|
boolean(&block, &ball, BoolOp::Cut).unwrap().unwrap()
|
|
}
|
|
|
|
/// The ball's rim on the back face dips to 0.04 mm above the bottom: a 0.5 mm chamfer of it
|
|
/// would run off the back face, and what was built grew the part (by 0.65 mm³, more with other
|
|
/// edge orders). On a convex edge a chamfer takes material away, so it is refused.
|
|
#[test]
|
|
fn a_chamfer_that_would_grow_the_part_on_a_convex_edge_is_refused() {
|
|
let body = block_with_ball_cut();
|
|
let rim = Vec3::new(3.1526309873924174, 22.5, 0.04277569594852188);
|
|
let e = chamfer(&body, &[rim], 0.5).expect_err("refused");
|
|
assert!(matches!(e, KernelError::TooLarge(_)) && e.to_string().contains("convex"), "{e}");
|
|
}
|
|
|
|
/// Curved convex edges that a chamfer does take material from still build: a hole's rim in a
|
|
/// plate.
|
|
#[test]
|
|
fn a_chamfer_of_a_hole_rim_still_builds() {
|
|
let plate = crate::box_solid(Vec3::new(0.0, 0.0, 0.0), Vec3::new(40.0, 30.0, 10.0)).unwrap();
|
|
let hole = crate::cylinder(Vec3::new(20.0, 15.0, -1.0), Vec3::Z, 5.0, 12.0).unwrap();
|
|
let body = boolean(&plate, &hole, BoolOp::Cut).unwrap().unwrap();
|
|
let v0 = crate::measure(&body).unwrap().volume;
|
|
let out = chamfer(&body, &[Vec3::new(25.0, 15.0, 10.0)], 1.0).unwrap();
|
|
assert!(out.validity().is_empty(), "{:?}", out.validity());
|
|
// A ring of a 1 mm chamfer round a 5 mm hole: (1/2)·2π·(5 + 1/3).
|
|
let taken = v0 - crate::measure(&out).unwrap().volume;
|
|
let want = std::f64::consts::PI * (5.0 + 1.0 / 3.0);
|
|
assert!((taken - want).abs() < 0.02 * want, "{taken} vs {want}");
|
|
}
|