Commit Graph
3392 Commits
Author SHA1 Message Date
Hakan Seven 6c0badbdc8 fix: resolve annotation pull request findings 2026-09-14 20:16:46 +03:00
Hakan Seven 293d0796fb Merge pull request #1246 2026-09-14 19:58:35 +03:00
Hakan Seven f2fd2ae5ad fix: address open pull request review findings 2026-09-14 19:58:35 +03:00
Hakan Seven 2d20bdd51c Merge pull request #1251 2026-09-14 19:51:57 +03:00
Hakan Seven f79594db38 Merge pull request #1260 2026-09-14 19:49:24 +03:00
Hakan Seven b48157a5af Merge pull request #1258 2026-09-14 19:49:24 +03:00
Hakan Seven 05baa82241 Merge pull request #1256 2026-09-14 19:49:24 +03:00
Hakan Seven 17f345953e Merge pull request #1253 2026-09-14 19:49:24 +03:00
Hakan Seven 61289bfa60 Merge pull request #1252 2026-09-14 19:49:24 +03:00
Hakan Seven b58d21a2c9 Merge pull request #1250 2026-09-14 19:49:24 +03:00
Hakan Seven ddabc2658a Merge pull request #1249 2026-09-14 19:49:24 +03:00
ramox81 0cabe113c8 Fix helix height from point input 2026-09-14 17:36:33 +03:00
ramox81 a28a9088d7 Use viewport UCS status fields 2026-09-14 16:57:58 +03:00
ramox81 88839b783a Match active view properties palette 2026-09-14 16:56:48 +03:00
ramox81 7dabc48fd3 Match Region properties palette 2026-09-14 16:16:20 +03:00
ramox81 666b28ffe3 fix(annotate): reject invalid linked ranges 2026-09-14 15:07:51 +03:00
ramox81 a35c996f9f fix(annotate): complete table and data workflows 2026-09-14 14:54:55 +03:00
kevin9327andClaude Opus 5 85e942bdd2 fix(step): keep the own plane of small triangles
The vertex-normal fallback compared the cross product's length with
f64::EPSILON, an area-scale threshold, so a valid triangle small enough
fell back to the leaning vertex normal again. Fall back only when the
cross product is zero.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-14 20:45:11 +09:00
kevin9327andClaude Opus 5 d77a3bd774 fix(stl): keep the own normal of small facets
The vertex-normal fallback compared the cross product's length with
f32::EPSILON, an area-scale threshold, so a valid facet with 1e-4 edges
(cross product 1e-8) took the leaning vertex normal again. Fall back only
when the cross product is zero.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-14 20:37:49 +09:00
kevin9327andClaude Opus 5 762705f4a4 fix(plot-style): keep the full scale factor when saving a plot style table
PlotStyleTable::to_text wrote scale_factor with one decimal, and saving
from the plot style panel rewrites the whole loaded table. A table with
apply_factor on and scale_factor=0.25 came back as 0.2, thinning every
scaled lineweight by a fifth.

Write the factor in full, keeping the decimal point on a whole value.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-14 20:29:03 +09:00
Hakan Seven 912b217d26 fix: delegate dimension transforms to cadcodec 2026-09-14 14:22:10 +03:00
kevin9327andClaude Opus 5 96a54b809c fix(linetypes): load .lin definitions whose header has no description
In a .lin file the description is optional and the comma goes with it, so
"*PLAIN" followed by "A,.5,-.25" is a complete definition. parse only kept
a header that contained a comma, so such a linetype was dropped silently
and a CENTERLTYPE naming it then reported that it was not loaded.

Take the whole header as the name when there is no comma.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-14 20:19:20 +09:00
Marcel a2adb3f6e3 Refactor grip dynamic input and polyline arc geometry 2026-09-14 13:15:57 +02:00
Hakan Seven 247e48bfe8 Merge pull request #1248 from kevin9327/fix/dimension-rotate-mirror-off-world-z 2026-09-14 14:15:11 +03:00
kevin9327andClaude Opus 5 6219af60ed fix(stl): write each facet's own normal
build_stl took the facet normal from the first vertex's normal whenever the
mesh had normals. On smoothed meshes (tessellated curved solids, OBJ imports
with vn) that normal leans off the triangle, while STL defines the facet
normal as the triangle's own unit normal.

Use the triangle's own normal, and keep the vertex normal only for a
triangle with no area. Meshes without normals export as before.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-14 20:11:30 +09:00
kevin9327andClaude Opus 5 bc3e63ff53 fix(step): place each exported face on its triangle's own plane
build_step took the PLANE normal from the first vertex's normal whenever
the mesh had normals. On smoothed meshes (tessellated curved solids, OBJ
imports with vn) that normal leans off the triangle, so the plane missed
two of the face's corners and the first edge was no longer perpendicular
to the placement axis.

Use the triangle's own normal, and keep the vertex normal only for a
triangle with no area. Meshes without normals export as before.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-14 20:04:00 +09:00
kevin9327andClaude Opus 5 23cd448c7f fix(dimension): rotate and mirror dimensions in working planes off world Z
With a working plane other than world XY, ROTATE and MIRROR handed a
non-ordinate dimension to acadrust's Entity::apply_transform, which only
translates those dimension types by where the transform sends the origin.
The definition points, plane and angles stayed unturned, so the dimension
jumped back once its block was baked again.

Send both through the existing Affine branch, which ALIGN already uses and
which transforms points, normal and stored angles together. The world-Z
paths are unchanged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-14 19:52:20 +09:00
Marcel dfc859dcf5 Restrict parallel offsets to straight polyline segments 2026-09-14 12:47:17 +02:00
Marcel 9ae1e6dd76 Preserve valid grip preview when edits have no geometric solution 2026-09-14 12:30:51 +02:00
Marcel 6f008faa9a Preserve connected arc geometry when moving polyline segments 2026-09-14 12:19:03 +02:00
Hakan Seven cba64631b8 fix: render PDF attachments on every platform
Fixes #1243
2026-09-14 12:53:06 +03:00
Marcel e67872386e Preserve connected arc geometry when moving polyline segments 2026-09-14 11:42:30 +02:00
Marcel fb352c34fb Add radius grip editing for LWPOLYLINE arcs 2026-09-14 10:58:45 +02:00
ramox81 6505b27818 fix(annotate): align annotation ribbon workflows 2026-09-14 11:55:08 +03:00
Hakan Seven 010d23fa95 chore: sync reviewed dependency mains 2026-09-14 10:02:49 +03:00
Hakan Seven 2f741d689f fix: address open PR review findings 2026-09-14 09:45:37 +03:00
Hakan Seven 3fe91fa6e1 Merge pull request #1240 from kevin9327/fix/step-export-large-coordinates 2026-09-14 09:29:08 +03:00
Hakan Seven 16a0f210d5 Merge pull request #1239 from kevin9327/fix/obj-import-missing-normals 2026-09-14 09:28:56 +03:00
Hakan Seven 28b49bf453 Merge pull request #1238 from kevin9327/fix/units-negative-zero 2026-09-14 09:28:45 +03:00
Hakan Seven ed09d287a4 Merge pull request #1237 from kevin9327/fix/linear-dim-rotate-mirror-axis 2026-09-14 09:28:31 +03:00
kevin9327andClaude Opus 5 d6a6b26675 fix(step): export mesh vertices with their low residual at large coordinates
Scene meshes store each position as an f32 half plus a low residual so
geometry stays precise at survey coordinates, and the renderer adds the
two back together. STEP export read only the f32 half. Near x = 500000
that half steps in 1/32 units, so a solid at 500000.123 was written as
500000.125, and the edge directions and planes were built from the same
snapped points.

Build each exported vertex from both halves in f64 and derive directions
and the fallback face normal from those. Meshes without a residual export
as before.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-14 08:59:58 +09:00
Hakan Seven fc1788df65 fix: export interoperable DWG constraint graphs 2026-09-14 02:57:33 +03:00
kevin9327andClaude Opus 5 977cdd4888 fix(obj): give faces without usable normals their face normal on import
IMPORTOBJ only computed face normals when the file listed no normals at
all. When a file did list some, a face that omitted its normal indices,
or pointed at an index past the end of the list, kept a zero normal. That
zero reaches the mesh shader, which normalizes it for lighting.

Track which vertices got a normal from the file and give the rest their
face normal. Supplied normals are kept, and a file without normals is
handled as before.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-14 08:51:03 +09:00
kevin9327andClaude Opus 5 19a0ac79ab fix(units): drop the minus sign from lengths and angles that round to zero
Rotating geometry leaves float noise in coordinates: turning the point
(0, 10) by 180 degrees gives X = -1.2246e-15. Rust formats that as
"-0.0000", so Properties showed "-0.0000" (or -0", -0d0'0", -0g) for a
value that is zero at the drawing's precision.

format_length and format_angle now drop the sign when every printed digit
is zero. Values that still show a digit keep it, and scientific notation
is unaffected.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-14 08:40:20 +09:00
kevin9327andClaude Opus 5 019447d9b5 fix(dimension): keep the linear measurement axis through ROTATE and MIRROR
ROTATE and MIRROR in the drawing plane moved a linear dimension's points
but left its stored rotation (the axis it measures along) unchanged. A
horizontal dimension rotated 90 degrees then measured its now-vertical
points along X and its value dropped to 0; mirroring about a slanted line
did the same. Polar ARRAY goes through the same path.

Turn the axis by the rotation angle, and reflect it about the mirror line.
A zero-length mirror line still leaves the dimension untouched.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-14 08:29:31 +09:00
Hakan Seven 7b4cef41f7 Complete parametric ribbon and constraint tools 2026-09-14 01:05:39 +03:00
Hakan Seven f3716bb516 Redesign parametric ribbon layout 2026-09-13 23:36:30 +03:00
Hakan Seven f47df9824d Arrange coincident constraint glyphs 2026-09-13 23:16:31 +03:00
Hakan Seven 5c9ca5b897 Improve constraint glyph placement and readability 2026-09-13 23:08:54 +03:00
Hakan Seven 78ab1c8013 Keep grip edits on the drawing plane and preserve constraint undo 2026-09-13 22:33:17 +03:00