Commit Graph
7 Commits
Author SHA1 Message Date
Helen Kwok cf004107b2 Keep the task a dispatched command returns
CmdResult::Dispatch and CmdResult::Relaunch end the active command and run the
assembled line through dispatch_command, then discarded the Task it returned
(`let _ =`). A command whose effect is a message carried by that Task was
announced but never applied. VSCURRENT's keyword picker is one: choosing
"Gouraud Shaded" printed "Visual style: Gouraud Shaded." and left the
drawing in wireframe, because SetRenderMode travels in that Task.

Hold the Task and batch it with the focus task that apply_cmd_result_inner
returns. A regression test drives both results through VSCURRENT and checks the
tab's render mode.
2026-09-20 13:17:05 +09:30
Helen Kwok 2e871c2c6c docs(automation): document driving the web build
Describe the two JavaScript functions the web build exposes
(ocs_control_submit / ocs_control_take), how to poll them, the queue and reply
limits, opening a drawing from bytes with data_base64, and closing the startup
dialog before new. Everything is taken from src/app/control/mod.rs,
src/app/startup.rs and docs/automation/web_save_smoke.cjs.
2026-09-20 12:50:39 +09:30
Helen Kwok be99983b72 Control: a point step that takes keywords accepts points
active_command_metadata listed one input kind per step. A point step that
also takes keyword letters (point_step_accepts_keywords) reports
SingleToken, so MOVE and COPY's base point with [Displacement] were
described as accepting only token and enter, and the input example was the
D keyword, though the step takes a point. List point as well; the keyword
letters are still listed as token from the options.
2026-09-19 18:01:14 +09:30
Helen Kwok 80d4adaee5 ci: type-check the web target on pushes to main and on pull requests
The web bundle is only built when a release is published, so a desktop-only
call in shared code can reach main unnoticed and fail the next release at
the wasm step (#1224, #1347). Run cargo check for wasm32-unknown-unknown on
the app and the web worker instead.
2026-09-19 14:48:47 +09:30
Helen Kwok 2a78ebe2c1 Web control: open a drawing from bytes
On the web build, {"op":"open","path":…} resolves the name against the
browser's recent-files cache, so a file that is not already there cannot be
opened by the control channel. Accept {"op":"open","name":…,
"data_base64":…} instead: the bytes go through the same parse, caching
and recovery path as a file chosen in the browser picker
(io::open_bytes_web, now shared with pick_and_load_web).

Native builds keep path-based open and reject data_base64 with
invalid_request.

Refs #1349
2026-09-18 16:43:29 +09:30
Helen Kwok be78ecc7d9 set_properties: compare expected numbers by value
serde_json keeps 10 and 10.0 as different Numbers, so an expected of 10
never matched a stored whole-number float, and a JavaScript client cannot
send 10.0 at all. Compare numbers by value (recursively through arrays and
objects); everything else keeps structural equality.

Fixes #1348
2026-09-18 15:46:23 +09:30
Helen Kwok 000d8a1687 Fix wasm32 build: gate the font download and XREF open call sites
crate::network and the open crate are desktop-only, but the community-font
download (font_repo.rs) and the XREF row Open action call them
unconditionally, so cargo check --target wasm32-unknown-unknown fails on
main. Gate both; on the web download_fonts returns an error, since the web
build has no network client or fonts folder.
2026-09-18 15:18:54 +09:30