Straight edges stay one edge after cuts (#1049) (#1101)

* Straight edges stay one edge after cuts (#1049)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Robustness goldens: cuts join straight edges along untouched walls (#1049)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fmt

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Robustness goldens note: what each changed seed shows when replayed on both builds

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

crates/sketch/src/link.rs

@@ -356,6 +356,44 @@ fn same_geometry(a: &[(LCurve, Vec<Vec2>)], b: &[(LCurve, Vec<Vec2>)]) -> bool {
 }
 
 /// The point indices a layout curve uses, in order.
+/// Is `fresh` the boundary `old` was, with only the stations along its straight lines gone
+/// (#1049: straight edges that booleans left split at vertices nothing else used are now one
+/// edge)? Every old line lies along exactly one fresh line and the old pieces cover it end to
+/// end; every other curve is unchanged. A link saved with the stations keeps its pieces then:
+/// the region they bound is the same, and the features that name them by id still find them.
+fn only_stations_gone(old: &[(LCurve, Vec<Vec2>)], fresh: &[(LCurve, Vec<Vec2>)]) -> bool {
+    const TOL: f64 = 1e-6;
+    let is_line = |c: &&(LCurve, Vec<Vec2>)| matches!(c.0, LCurve::Line(..));
+    let ends = |c: &(LCurve, Vec<Vec2>)| match c.1.as_slice() {
+        [a, b] => Some((*a, *b)),
+        _ => None,
+    };
+    let (old_lines, old_rest): (Vec<_>, Vec<_>) = old.iter().partition(is_line);
+    let (fresh_lines, fresh_rest): (Vec<_>, Vec<_>) = fresh.iter().partition(is_line);
+    if fresh_lines.len() >= old_lines.len() || old_lines.len() > 512 {
+        return false;
+    }
+    let rest = |xs: Vec<&(LCurve, Vec<Vec2>)>| xs.into_iter().cloned().collect::<Vec<_>>();
+    if !same_geometry(&rest(old_rest), &rest(fresh_rest)) {
+        return false;
+    }
+    let Some(fresh_segs) = fresh_lines.iter().map(|c| ends(c)).collect::<Option<Vec<_>>>() else { return false };
+    let mut covered = vec![0.0; fresh_segs.len()];
+    for c in &old_lines {
+        let Some((p, q)) = ends(c) else { return false };
+        let on = |x: Vec2, (a, b): (Vec2, Vec2)| {
+            let ab = b - a;
+            let t = ((x - a).dot(ab) / ab.dot(ab).max(f64::MIN_POSITIVE)).clamp(0.0, 1.0);
+            x.dist(a + ab * t) <= TOL * (1.0 + a.len().max(b.len()))
+        };
+        let Some(k) = fresh_segs.iter().position(|seg| on(p, *seg) && on(q, *seg)) else { return false };
+        if let Some(slot) = covered.get_mut(k) {
+            *slot += p.dist(q);
+        }
+    }
+    fresh_segs.iter().zip(&covered).all(|((a, b), len)| (a.dist(*b) - len).abs() <= TOL * (1.0 + a.len().max(b.len())))
+}
+
 fn curve_points(c: &LCurve) -> Vec<usize> {
     match *c {
         LCurve::Line(a, b) => vec![a, b],
@@ -677,9 +715,8 @@ impl Sketch {
             let lone_old: Vec<Vec2> = points.iter().filter_map(|pi| pos(*pi)).collect();
             if let (Some(old), Some(fresh)) = (old, fresh)
                 && lay.lone.is_empty()
-                && points.len() == lay.pts.len()
                 && lone_old.len() == points.len()
-                && same_geometry(&old, &fresh)
+                && (points.len() == lay.pts.len() && same_geometry(&old, &fresh) || only_stations_gone(&old, &fresh))
             {
                 return Ok(false);
             }

crates/sketch/src/tests.rs

@@ -883,3 +883,41 @@ fn exact_profiles_for_high_degree_and_cut_free_form_curves() {
     let uncut: f64 = find_profiles(&sk).iter().map(|p| p.area).sum();
     assert!((whole - uncut).abs() < 1e-6 * uncut, "{whole} vs {uncut}");
 }
+
+/// A face boundary saved with stations along its straight edges (#1049: booleans used to leave
+/// vertices nothing else used) keeps its saved pieces when the face comes back with each
+/// straight edge whole: the same region, and features that name the pieces still find them.
+#[test]
+fn projected_boundary_keeps_its_pieces_when_only_stations_go() {
+    use crate::{LinkGeom, LinkKind, LinkSource};
+    let mut sk = Sketch::new();
+    let v = Vec2::new;
+    let split = vec![
+        LinkGeom::Line(v(0.0, 0.0), v(5.0, 0.0)),
+        LinkGeom::Line(v(5.0, 0.0), v(10.0, 0.0)),
+        LinkGeom::Line(v(10.0, 0.0), v(10.0, 4.0)),
+        LinkGeom::Line(v(10.0, 4.0), v(10.0, 10.0)),
+        LinkGeom::Line(v(10.0, 10.0), v(0.0, 10.0)),
+        LinkGeom::Line(v(0.0, 10.0), v(0.0, 0.0)),
+    ];
+    let j = sk.add_link(LinkKind::Project, LinkSource::Origin, &split).unwrap();
+    let ids: Vec<String> = sk.link_curves(&j).iter().map(|c| sk.curves[*c].id.clone()).collect();
+    let whole = vec![
+        LinkGeom::Line(v(0.0, 0.0), v(10.0, 0.0)),
+        LinkGeom::Line(v(10.0, 0.0), v(10.0, 10.0)),
+        LinkGeom::Line(v(10.0, 10.0), v(0.0, 10.0)),
+        LinkGeom::Line(v(0.0, 10.0), v(0.0, 0.0)),
+    ];
+    assert!(!sk.update_link(&j, &whole).unwrap(), "only the stations went: the pieces stay");
+    let kept: Vec<String> = sk.link_curves(&j).iter().map(|c| sk.curves[*c].id.clone()).collect();
+    assert_eq!(ids, kept);
+    // A boundary that really changed is rebuilt.
+    let smaller = vec![
+        LinkGeom::Line(v(0.0, 0.0), v(8.0, 0.0)),
+        LinkGeom::Line(v(8.0, 0.0), v(8.0, 10.0)),
+        LinkGeom::Line(v(8.0, 10.0), v(0.0, 10.0)),
+        LinkGeom::Line(v(0.0, 10.0), v(0.0, 0.0)),
+    ];
+    assert!(sk.update_link(&j, &smaller).unwrap());
+    assert_eq!(sk.link_curves(&j).len(), 4);
+}